Add Support for INA228 #17994
Merged
Add Support for INA228 #17994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagar
reviewed
Jul 29, 2021
dagar
reviewed
Jul 29, 2021
davids5
commented
Jul 30, 2021
davids5
force-pushed
the
pr-ini228
branch
3 times, most recently
from
e0187b8
to
24234b7
Compare
Merged
|
@dagar - Changes we discussed are in. In retrospect, this assume bus 1 and 2 for the general case (in in rc.sensors) - which is fine as the current use cases. But might not be a general solution, as this is board wiring specific. |
|
@dagar - back to board wiring specific |
dagar
added
Drivers 🔧
dagar
approved these changes
Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing only!
Start with
ina228 -X -b 1 startWhen connected to power brick 1ina228 -X -b 2 startWhen connected to power brick 2.I am seeing higher the real current values.
Measurements of the Pin 9-10 are 0.43 mA > than on the shunt.